Indeed, I've missed that case and have no nonreg test for -2ch

that I should have catched then. Sigh.

only affect array concat

by grouping instances of the same type into arrays.

The rationale is to be able to generate for loops with iterators.

The previous code was working, but probably by chance.

e.g., for arrays.

No test actually catches this bug.

Now all the tests that were ok in the heap mode are also ok in the
stack mode !

However the code generated for programs that use fillred and co is weird.

For instance, in should_work.pipeline.lus, in
fillred_oneStep_pipe_10_step, accu_in is used both as an input and an
output, which seems wrong in the stack mode as no copy is performed.

Is it working by chance ?

Now all the tests that were ok in the heap mode are also ok in the
stack mode !

However the code generated by fillred and co is weird.

For instance, in should_work.pipeline.lus, in
fillred_oneStep_pipe_10_step, accu_in is used both as an input and an
output, which seems wrong in the stack mode as no copy is performed.

Is it working by chance ?

Indeed, in order to copy an array, I used to generate something like

   memcpy(out, in, sizeof(in));

but if 'out' and 'in' are arrays, and if 'in' is an argument of a function,
sizeof() considers it as a pointer, not an array !!!!

note that if 'in' is a local var, sizeof(in) works fine.

To fix it, I use the type of the dest (instead of the id) as argument of sizeof.

nb : The pb never occured before, as in the heap mode only the ctx is
passed a args of step functions.

when calling soc.

Do not work all the times (eg, with arrays it generates C code that
does not compile). cf next changes.

Report by willie (cf mail of 8/10/2014 to get the file)

file:/tmp/modes3x2.lus

lus2lic -esa -en -2c /tmp/modes3x2.lus -n modes3x2

But it gives an error of:
Error. in file "/mnt/A/wsept/modes3x2_pre_orig_lus2lic_en_esa/modes3x2.lus",
line 74, col 8 to 8, token '#': only one operator per equation is allowed
(v04_0, v04_1).

Which is the line:
assert #(on_off, toggle);

-----------------------------------------------------------------

Actually, refuse programs that uses "#" or "nor" run with -esa and
-2c|-exec

That means that willie program is now rejected.

Nevertheless, that change migth fix some other programs (that uses
arrays, and used with -esa and -exec or -2c).

Also fix a bug in Lic2soc.make_e2a_elt where some deps and some
actions were lost. Actually, this bug ought to be triggered only with
nested calls. So this affects only programs executed via the
-knc/-keep-nested-calls option. and -2c is not supposed to work in
conjunction with -knc ! Hence this fix does not fix anything. But
still it fixes potentially future code if I (or someone else) decide
to handle nested calls in the lic one day.

More precisely, it was introduced here 6c7bc562

bug1: Soc2cGenAssign.f was calling Soc2cIdent.type_to_short_string,
which was generating bad idents (ie, containing "::").

bug2 : some _assign_array_types macro def were missing.

to be continued...

The rationale is to prepare the work for a future --2s-stack option.

soc2c: fix the code generated for array concatenation (which was raising a warning and a Seg fault).

nb : the -exec mode was working because I did not use the generated soc,
which was completely wrong.

Note that to do that, I have modified the CURRENT variant of
Lic.val_exp, to attach it the clock the current holds on. Indeed, the
clock is mandatory to generated correct code...

In an ideal world, this clock information may have explicitely been
set by the user ("current(clk_of_X,X)" instead of "current(X)"), but
for historical reason, it is not the case.

Hence, this information is added as soon as it is available, namely,
during clock checking.

Indeed, ite are polymorphic, and thus inventing names during soc
instanciation is error-prone, ugly, innefficient, and increase the
code size.

Moreover, using C ite to translate them online (ie, without going
trough a soc) is straigforward

# of unexpected failures	104->101.

nb:  unexpected failures  120 -> 118

I've sligthly modified the profile of gen_assign to explicitly ask for the
size of the data structure to be copied.

nb:  unexpected failures 131 -> 127

nb:  unexpected failures	144->143

nb:  unexpected failures	149->144

The arrow soc now has a memory used to hold if the first step has be triggered.

nb:  unexpected failures 175-> 162

Also name step function consistent and uniquely

nb:  unexpected failures 187->175

nb:  unexpected failures 195->187

Also start to add support for the other iterators, but it does not work yet.

nb: 20 more tests passes.

Always use Soc2cPredef.gen_assign to generate var assignments.

Also, use affection for assigning structures.

nb: 21 more tests passes.

Also do not crash if the soc contains reference to extern types.

- Generate code for most predef operators.
- Generate a loop.c file (in a similar manner as ec2c -loop does)