Skip to content
Snippets Groups Projects
  1. May 26, 2009
    • Erwan Jahier's avatar
      Attach the clock of Eff.val_exp to the val_exp itself, instead of · e7ef1b90
      Erwan Jahier authored
      maintaining (ugly and error-prone) hash tables.
      
      That change revealed an untriggered bug in EvalClock.check_args: it was wrong
      to add in subst the substitutions made of the parameters and the arguments (it
      is enough to unify the clocks of the pars and of the args). For instance, consider
      the node (in should_work/clock/clock.lus)
      
         node clock5(x :  bool; y:  bool when x; z: bool when y)
      
      and the call
      
        z2 = clock5(a, b when a, c when e);
      
      I was adding y/b in the subst, which was wrong.
      
      Other minor changes:
       - move const_to_val_eff from Eff to UnifyClock.
       - GetEff.translate_val_exp now returns a substitution, in order to be able
         to unify clock vars and propagate the resulting substitution.
      e7ef1b90
  2. Mar 12, 2009
  3. Mar 11, 2009
  4. Mar 09, 2009
  5. Feb 25, 2009
  6. Feb 10, 2009
  7. Dec 12, 2008
    • Erwan Jahier's avatar
      Break the recursivity is the Eff.node_exp representation (which fix nested iter. pbs). · 5c722d86
      Erwan Jahier authored
      In  short, the  rationale for  this change,  is that  it is  having a
      recursive node_exp is
      - useless,
      - too complicated,
      - wrong w.r.t. nesting iterator calls
      
      In long:
      
      - It is useless because, at the  Eff level, a node cannot call itself
        via one  of its  static arg (which  was where the  recursivity came
        from).
      
      - and indeed, it  is much simpler to consider that  a static arg node
        can only be ident.long that identifies a node alias.
      
        This  means of  course, that  nested iterators  have  been unnested
        before,   inventing  alias   node  names   along  the   way...  And
        polymorphism makes thing difficult once again.
      
      - But the  *big* problem  with a recursive  node_exp is that  it make
        things very  complicated to (lic)dump nested  iterator call because
        of polymorphism!   Actually, it  even makes thing  complicated when
        the iterators were themselves not nested in the source code !
      
        Some ugly  things were done in  LicDump to unnest  those calls when
        printing node_exp.   But this uglyness  have a price:  tricky code,
        and bugs! Indeed, nested iterators calls were wong for example when
        using  the --inline-iterator  mode (but  i would  not  be surprised
        that is wrong in other cases...).
      
      Hence,  LicDump  is  simpler,  but  of course  LazyCompiler  is  more
      complicated.  But  this  is  reasonable:  a  pretty-printer  is  not
      supposed to be complicated.
      5c722d86
  8. Nov 28, 2008
  9. Nov 26, 2008
  10. Nov 25, 2008
    • Erwan Jahier's avatar
      Replace constants by their values. · 3f2aa6c4
      Erwan Jahier authored
      The rationale for this change is that this is necessary for constants
      appearing static  arg to  be replaced. One  problem is that  they are
      handled in exactly  the same way as top-level  constants, which could
      be left  un-expanded. I could make  something in order  to not expand
      those top-levelconstants, but is it worth the trouble ?
      
      To do that,  I have changed sligthly the  representation of Eff.ARRAY
      (the elements  are now  attached to the  constructor itself,  and the
      operands  is empty)  and  the one  of  array constant  (we attach  to
      Array_const_eff  a  list  instead  of  an  array,  for  the  sake  of
      homogeneity) with what is done in Eff.val_eff.
      3f2aa6c4
  11. Nov 21, 2008
  12. Nov 20, 2008
  13. Nov 04, 2008
  14. Nov 03, 2008
  15. Sep 15, 2008
  16. Sep 02, 2008
  17. Sep 01, 2008
  18. Aug 29, 2008
  19. Aug 28, 2008
  20. Aug 25, 2008
    • Erwan Jahier's avatar
      Unnest array iterator calls by modifying the Lic printer. · 65c62005
      Erwan Jahier authored
      The  idea  is  the  following:  each  time  a  nested  iterator  call
      (map<<map<<n,3>>,4>>) is  encountered, we  create a fresh  alias name
      (create_alias_name) ad we  add it in the node_alias_tbl.   At the end
      of the  compilation, LicDump.dump_node_alias is  called, which prints
      the definition of those node aliases.
      
      For example, the expression  "map<<map<<n,3>>,4>>" is printed like this:
      
          map<<_node_alias1, 4>>
      
      and later, the node alias is defined:
      
          node _node_alias1(x:int) returns(y:int); let y = map<<n,3>>(x); tel;
      65c62005
  21. Aug 21, 2008
  22. Aug 20, 2008
  23. Aug 19, 2008
    • Erwan Jahier's avatar
      Split expressions into atomic expressions. In other words, introduce · d7905aff
      Erwan Jahier authored
      as many  new local  variables as necessary  so that an  expression is
      made at most of one operator.
      
      The rational  for that  is to obtain  a lic  code that is  trivial to
      clock check (nested node calls, for example, make it less simple).
      
      The old behavior can still be obtained using --keep-nested-calls.
      
      During  that  change,   I  realised  that  I  did   not  clock  check
      asserts. Hence, I have also added this check.
      d7905aff
Loading