-
- Downloads
Canceling pagination caused by execution command from command line aborts readline/gdb
This fixes: $ ./gdb program -ex "set height 2" -ex "start" ... Reading symbols from /home/pedro/gdb/tests/threads...done. ---Type <return> to continue, or q <return> to quit---^CQuit << ctrl-c triggers a Quit *type something* readline: readline_callback_read_char() called with no handler! Aborted $ Usually, if an error propagates all the way to the top level, we'll re-enable stdin, in case the command that was running was a synchronous command. That's done in the event loop's actual loop (event-loop.c:start_event_loop). However, if a foreground execution command is run before the event loop starts and throws, nothing is presently reenabling stdin, which leaves sync_execution set. When we do start the event loop, because sync_execution is still (mistakenly) set, display_gdb_prompt removes the readline input callback, even though stdin is registered in the event loop. Any input from here on results in readline aborting. Such commands are run through catch_command_errors, catch_command_errors_const, so add the tweak there. gdb/ 2014-07-14 Pedro Alves <palves@redhat.com> PR gdb/17072 * main.c: Include event-top.h. (handle_command_errors): New function. (catch_command_errors, catch_command_errors_const): Use it. gdb/testsuite/ 2014-07-14 Pedro Alves <palves@redhat.com> PR gdb/17072 * gdb.base/paginate-execution-startup.c: New file. * gdb.base/paginate-execution-startup.exp: New file. * lib/gdb.exp (pagination_prompt): New global. (default_gdb_spawn): New procedure, factored out from default_gdb_spawn. (default_gdb_start): Adjust to call default_gdb_spawn. (gdb_spawn): New procedure.
Showing
- gdb/ChangeLog 7 additions, 0 deletionsgdb/ChangeLog
- gdb/main.c 22 additions, 8 deletionsgdb/main.c
- gdb/testsuite/ChangeLog 11 additions, 0 deletionsgdb/testsuite/ChangeLog
- gdb/testsuite/gdb.base/paginate-execution-startup.c 32 additions, 0 deletionsgdb/testsuite/gdb.base/paginate-execution-startup.c
- gdb/testsuite/gdb.base/paginate-execution-startup.exp 189 additions, 0 deletionsgdb/testsuite/gdb.base/paginate-execution-startup.exp
- gdb/testsuite/lib/gdb.exp 49 additions, 12 deletionsgdb/testsuite/lib/gdb.exp
Loading
Please register or sign in to comment