Skip to content
Snippets Groups Projects
Commit 593dda18 authored by Tom de Vries's avatar Tom de Vries
Browse files

[gdb/testsuite] Fix gdbserver path in remote-stdio-gdbserver.exp

With test-case gdb.server/unittest.exp and target board remote-stdio-gdbserver
I run into:
...
(gdb) builtin_spawn /usr/bin/ssh -t -l vries localhost /usr/bin/gdbserver \
  --selftest^M
Selftests have been disabled for this build.^M
UNSUPPORTED: gdb.server/unittest.exp: unit tests
...
due to using the system gdbserver /usr/bin/gdbserver rather than the one from
the build.

Fix this by removing the hard-coding of /usr/bin/gdbserver in
remote-stdio-gdbserver, allowing find_gdbserver to do its work, such that we
have instead:
...
(gdb) builtin_spawn /usr/bin/ssh -t -l vries localhost \
  /data/vries/gdb/leap-15-4/build/gdbserver/gdbserver --selftest^M
Running selftest remote_memory_tagging.^M
Ran 1 unit tests, 0 failed^M
Connection to localhost closed.^M^M
PASS: gdb.server/unittest.exp: unit tests
...

Tested on x86_64-linux.
parent 6407713f
No related branches found
No related tags found
No related merge requests found
...@@ -47,11 +47,9 @@ if [info exists REMOTE_TMPDIR] { ...@@ -47,11 +47,9 @@ if [info exists REMOTE_TMPDIR] {
set_board_info remotedir $REMOTE_TMPDIR set_board_info remotedir $REMOTE_TMPDIR
} }
unset_board_info gdb_server_prog
if [info exists GDBSERVER] { if [info exists GDBSERVER] {
unset_board_info gdb_server_prog
set_board_info gdb_server_prog $GDBSERVER set_board_info gdb_server_prog $GDBSERVER
} else {
set_board_info gdb_server_prog /usr/bin/gdbserver
} }
proc get_remote_login { } { proc get_remote_login { } {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment