Skip to content
Snippets Groups Projects
  • Alan Modra's avatar
    13acb58d
    PR27716, build failure for msdosdjgpp: PATH_MAX undeclared · 13acb58d
    Alan Modra authored
    We shouldn't be using arbitrary limits like PATH_MAX in GNU programs.
    This patch also fixes some memory leaks in readelf when processing
    separate debug info.
    
    	PR 27716
    binutils/
    	* objdump.c (show_line): Don't limit paths to PATH_MAX.
    	* readelf.c (struct filedata): Change program_interpreter from
    	a char array to a char pointer.
    	(process_program_headers): Sanity check PT_INTERP p_filesz.
    	Malloc program_interpreter using p_filesz and read directly from
    	file.
    	(process_dynamic_section): Check program_interpreter is non-NULL.
    	(free_filedata): New function, split out from..
    	(process_object): ..here.
    	(close_debug_file): Call free_filedata.
    	* sysdep.h: Don't include sys/param.h.
    	(PATH_MAX): Don't define.
    	* configure.ac: Don't check for sys/param.h.
    	* configure: Regenerate.
    gprof/
    	* gprof.h (PATH_MAX): Don't define.
    	* corefile.c (core_create_line_syms): Don't use PATH_MAX for initial
    	file name size.
    	* source.c (annotate_source): Malloc file name buffer.  Always
    	trim off "-ann" when dos 8.3 annotate file matches original.
    	* utils.c (print_name_only): Malloc file name buffer.
    13acb58d
    History
    PR27716, build failure for msdosdjgpp: PATH_MAX undeclared
    Alan Modra authored
    We shouldn't be using arbitrary limits like PATH_MAX in GNU programs.
    This patch also fixes some memory leaks in readelf when processing
    separate debug info.
    
    	PR 27716
    binutils/
    	* objdump.c (show_line): Don't limit paths to PATH_MAX.
    	* readelf.c (struct filedata): Change program_interpreter from
    	a char array to a char pointer.
    	(process_program_headers): Sanity check PT_INTERP p_filesz.
    	Malloc program_interpreter using p_filesz and read directly from
    	file.
    	(process_dynamic_section): Check program_interpreter is non-NULL.
    	(free_filedata): New function, split out from..
    	(process_object): ..here.
    	(close_debug_file): Call free_filedata.
    	* sysdep.h: Don't include sys/param.h.
    	(PATH_MAX): Don't define.
    	* configure.ac: Don't check for sys/param.h.
    	* configure: Regenerate.
    gprof/
    	* gprof.h (PATH_MAX): Don't define.
    	* corefile.c (core_create_line_syms): Don't use PATH_MAX for initial
    	file name size.
    	* source.c (annotate_source): Malloc file name buffer.  Always
    	trim off "-ann" when dos 8.3 annotate file matches original.
    	* utils.c (print_name_only): Malloc file name buffer.