Skip to content
Snippets Groups Projects
  • Pedro Alves's avatar
    264f9890
    event_location -> location_spec · 264f9890
    Pedro Alves authored
    Currently, GDB internally uses the term "location" for both the
    location specification the user input (linespec, explicit location, or
    an address location), and for actual resolved locations, like the
    breakpoint locations, or the result of decoding a location spec to
    SaLs.  This is expecially confusing in the breakpoints module, as
    struct breakpoint has these two fields:
    
      breakpoint::location;
      breakpoint::loc;
    
    "location" is the location spec, and "loc" is the resolved locations.
    
    And then, we have a method called "locations()", which returns the
    resolved locations as range...
    
    The location spec type is presently called event_location:
    
      /* Location we used to set the breakpoint.  */
      event_location_up location;
    
    and it is described like this:
    
      /* The base class for all an event locations used to set a stop event
         in the inferior.  */
    
      struct event_location
      {
    
    and even that is incorrect...  Location specs are used for finding
    actual locations in the program in scenarios that have nothing to do
    with stop events.  E.g., "list" works with location specs.
    
    To clean all this confusion up, this patch renames "event_location" to
    "location_spec" throughout, and then all the variables that hold a
    location spec, they are renamed to include "spec" in their name, like
    e.g., "location" -> "locspec".  Similarly, functions that work with
    location specs, and currently have just "location" in their name are
    renamed to include "spec" in their name too.
    
    Change-Id: I5814124798aa2b2003e79496e78f95c74e5eddca
    264f9890
    History
    event_location -> location_spec
    Pedro Alves authored
    Currently, GDB internally uses the term "location" for both the
    location specification the user input (linespec, explicit location, or
    an address location), and for actual resolved locations, like the
    breakpoint locations, or the result of decoding a location spec to
    SaLs.  This is expecially confusing in the breakpoints module, as
    struct breakpoint has these two fields:
    
      breakpoint::location;
      breakpoint::loc;
    
    "location" is the location spec, and "loc" is the resolved locations.
    
    And then, we have a method called "locations()", which returns the
    resolved locations as range...
    
    The location spec type is presently called event_location:
    
      /* Location we used to set the breakpoint.  */
      event_location_up location;
    
    and it is described like this:
    
      /* The base class for all an event locations used to set a stop event
         in the inferior.  */
    
      struct event_location
      {
    
    and even that is incorrect...  Location specs are used for finding
    actual locations in the program in scenarios that have nothing to do
    with stop events.  E.g., "list" works with location specs.
    
    To clean all this confusion up, this patch renames "event_location" to
    "location_spec" throughout, and then all the variables that hold a
    location spec, they are renamed to include "spec" in their name, like
    e.g., "location" -> "locspec".  Similarly, functions that work with
    location specs, and currently have just "location" in their name are
    renamed to include "spec" in their name too.
    
    Change-Id: I5814124798aa2b2003e79496e78f95c74e5eddca