Skip to content
Snippets Groups Projects
  • Tom Tromey's avatar
    12c58cd4
    Avoid -Wduplicated-cond warnings in gdb/python · 12c58cd4
    Tom Tromey authored
    I tried building gdb with -Wduplicated-cond.  This patch fixes the
    simpler issue that was found.
    
    In Python 3, "int" and "long" are synonyms, so code like:
    
          else if (PyLong_Check (obj))
    ...
          else if (PyInt_Check (obj))
    
    .... will trigger this warning.  The fix is to conditionalize the
    PyInt_Check branches on Python 2.
    
    Tested by rebuilding, with both version of Python, on x86-64 Fedora 24.
    
    2016-09-20  Tom Tromey  <tom@tromey.com>
    
    	* python/py-value.c (convert_value_from_python): Make PyInt_Check
    	conditional on Python 2.
    	* python/py-arch.c (archpy_disassemble): Make PyInt_Check
    	conditional on Python 2.
    12c58cd4
    History
    Avoid -Wduplicated-cond warnings in gdb/python
    Tom Tromey authored
    I tried building gdb with -Wduplicated-cond.  This patch fixes the
    simpler issue that was found.
    
    In Python 3, "int" and "long" are synonyms, so code like:
    
          else if (PyLong_Check (obj))
    ...
          else if (PyInt_Check (obj))
    
    .... will trigger this warning.  The fix is to conditionalize the
    PyInt_Check branches on Python 2.
    
    Tested by rebuilding, with both version of Python, on x86-64 Fedora 24.
    
    2016-09-20  Tom Tromey  <tom@tromey.com>
    
    	* python/py-value.c (convert_value_from_python): Make PyInt_Check
    	conditional on Python 2.
    	* python/py-arch.c (archpy_disassemble): Make PyInt_Check
    	conditional on Python 2.