From 9e036b2d6553b47c8d556a29b96e3b3215f4a338 Mon Sep 17 00:00:00 2001 From: Daniel Nelson <daniel.nelson@influxdb.com> Date: Tue, 28 Mar 2017 12:31:36 -0700 Subject: [PATCH] Remove wait loop in riemann tests This testcase still has a race condition but I believe it is when the test does not complete quickly enough. --- plugins/outputs/riemann/riemann_test.go | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/plugins/outputs/riemann/riemann_test.go b/plugins/outputs/riemann/riemann_test.go index 67a161be..0b7c8540 100644 --- a/plugins/outputs/riemann/riemann_test.go +++ b/plugins/outputs/riemann/riemann_test.go @@ -193,17 +193,6 @@ func TestConnectAndWrite(t *testing.T) { err = r.Write(metrics) require.NoError(t, err) - start := time.Now() - for true { - events, _ := r.client.Query(`tagged "docker"`) - if len(events) > 0 { - break - } - if time.Since(start) > time.Second { - break - } - } - // are there any "docker" tagged events in Riemann? events, err := r.client.Query(`tagged "docker"`) require.NoError(t, err) -- GitLab