diff --git a/plugins/inputs/statsd/running_stats.go b/plugins/inputs/statsd/running_stats.go index 3ce03a87760d7985ec8c3e927a4ccb13879646b9..2395ab143f45d51f3372f7cf59291f59d8d29a94 100644 --- a/plugins/inputs/statsd/running_stats.go +++ b/plugins/inputs/statsd/running_stats.go @@ -110,8 +110,15 @@ func (rs *RunningStats) Percentile(n int) float64 { } i := int(float64(len(rs.perc)) * float64(n) / float64(100)) - if i < 0 { - i = 0 + return rs.perc[clamp(i, 0, len(rs.perc)-1)] +} + +func clamp(i int, min int, max int) int { + if i < min { + return min + } + if i > max { + return max } - return rs.perc[i] + return i } diff --git a/plugins/inputs/statsd/running_stats_test.go b/plugins/inputs/statsd/running_stats_test.go index 614de9cec657d9c633a24fdf87d11b5a0ed244af..4571f76d7a60256823a4291f078349fd89411518 100644 --- a/plugins/inputs/statsd/running_stats_test.go +++ b/plugins/inputs/statsd/running_stats_test.go @@ -23,12 +23,18 @@ func TestRunningStats_Single(t *testing.T) { if rs.Lower() != 10.1 { t.Errorf("Expected %v, got %v", 10.1, rs.Lower()) } + if rs.Percentile(100) != 10.1 { + t.Errorf("Expected %v, got %v", 10.1, rs.Percentile(100)) + } if rs.Percentile(90) != 10.1 { t.Errorf("Expected %v, got %v", 10.1, rs.Percentile(90)) } if rs.Percentile(50) != 10.1 { t.Errorf("Expected %v, got %v", 10.1, rs.Percentile(50)) } + if rs.Percentile(0) != 10.1 { + t.Errorf("Expected %v, got %v", 10.1, rs.Percentile(0)) + } if rs.Count() != 1 { t.Errorf("Expected %v, got %v", 1, rs.Count()) } @@ -58,12 +64,18 @@ func TestRunningStats_Duplicate(t *testing.T) { if rs.Lower() != 10.1 { t.Errorf("Expected %v, got %v", 10.1, rs.Lower()) } + if rs.Percentile(100) != 10.1 { + t.Errorf("Expected %v, got %v", 10.1, rs.Percentile(100)) + } if rs.Percentile(90) != 10.1 { t.Errorf("Expected %v, got %v", 10.1, rs.Percentile(90)) } if rs.Percentile(50) != 10.1 { t.Errorf("Expected %v, got %v", 10.1, rs.Percentile(50)) } + if rs.Percentile(0) != 10.1 { + t.Errorf("Expected %v, got %v", 10.1, rs.Percentile(0)) + } if rs.Count() != 4 { t.Errorf("Expected %v, got %v", 4, rs.Count()) } @@ -93,12 +105,18 @@ func TestRunningStats(t *testing.T) { if rs.Lower() != 5 { t.Errorf("Expected %v, got %v", 5, rs.Lower()) } + if rs.Percentile(100) != 45 { + t.Errorf("Expected %v, got %v", 45, rs.Percentile(100)) + } if rs.Percentile(90) != 32 { t.Errorf("Expected %v, got %v", 32, rs.Percentile(90)) } if rs.Percentile(50) != 11 { t.Errorf("Expected %v, got %v", 11, rs.Percentile(50)) } + if rs.Percentile(0) != 5 { + t.Errorf("Expected %v, got %v", 5, rs.Percentile(0)) + } if rs.Count() != 16 { t.Errorf("Expected %v, got %v", 4, rs.Count()) }