GitLab

Fix: the Register.diameter returned the links number (introduced in sha:40eece7c)

- add sub_tree_size, parent, is_in_tree, is_out_tree
- fix height (was only working for out-trees)
- a predessors to Topology.t
- refactor a lot of strange things in the code
  - in the use of hashtbl in particular

and attach  the pid to  the list of neighbors  of returned by  the get
function. Indeed, this is needed in some anomymous (or semi-anonymous)
algorithms, such as the k-clustering.

It now takes  as first argument the whole list  of processes (not only
the enabled ones).

In  Algo.pf_info, the  action  field  is now  an  option  type (if  is
correspond to a process that has not been activated).

Update: add the previous state in argument of the fault function.

New: add a fault functions to the Algo (to inject fault when a legitimate configuratiuon is reached).

nb: I needed to  split Main to avoid a Module self-loop  (as I need to
use do_step in Daemon).

The  rationale is  that the  Algo.spid that  gave processes  access to
their pid via their neighbors was a bit weird. Also, it makes the anonymity
of the algorithm more explicit: an access to the pid could appear anywhere
in the program, while now, the pid must be in state.t!

Now, if the  user needs the pid,  he must store it  explicitly in the
state via the initialization function.

To force that, I've changed the Register interface (and thus GenRegister)

The rationale is that:
- in lurette mode, they should be the same for all algos already
- in batch mode, action declarations are ignored anyway (except in custom mode)

as it is where they belong.

Add use it to add an oracle to the BFS

Took into account Erwan's comments and changed Register module such that the properties are computed on first call (except height that is computed on each call because it depends on the chosen tree's root)

All the get_* functions (that are of no interest for users) are now in
the Register module.

Things that are currently broken:
- the ability to init vars in the dot
- controling the name of local vars in the rif output

The idea is to use the Obj module (arg !!!), which is safe thanks to
the fact that there is now only one register function, which forces all the
'v to be bound to the same type.

But I bumped into the "value restriction" limitation
https://stackoverflow.com/questions/22507448/the-value-restriction

Indeed, I need to store functions of 'v in some tables (or references),

And tables are necessaryly weakly polymorphic !

https://v1.realworldocaml.org/v1/en/html/imperative-programming-1.html#side-effects-and-weak-polymorphism

Indeed, by using the Env.nset and Env.nget defined in
0d6575a7 a pb that was hided by the
use of Env.set and Env.get was triggered.

The bug was that variables initialisations were done several times.

In sasa.ml, the way I was updating the Env.t by iterating on the
variables was forcing to "close" expressions that were calling init
functions.