OMEGAlpes issueshttps://gricad-gitlab.univ-grenoble-alpes.fr/omegalpes/omegalpes/-/issues2020-05-04T11:01:29+02:00https://gricad-gitlab.univ-grenoble-alpes.fr/omegalpes/omegalpes/-/issues/57Good practices for OMEGAlpes' development2020-05-04T11:01:29+02:00Sacha HodencqGood practices for OMEGAlpes' development[This good to read article](https://www-ncbi-nlm-nih-gov/pmc/articles/PMC5480810/ "Good enough practices in scientific computing, Wilson et al., 2017") summarises good practices for Open Source Software development. While many are alread...[This good to read article](https://www-ncbi-nlm-nih-gov/pmc/articles/PMC5480810/ "Good enough practices in scientific computing, Wilson et al., 2017") summarises good practices for Open Source Software development. While many are already checked in OMEGAlpes project, some can be put in place:
- 3e: Make the project citable (3e) by including a CITATION file in the project's home directory
- 4b,c,d,e: src, bin, doc and results directory (see if relevant here)
- 5f Add a file called CHANGELOG.txt to the project's docs subfolder, and make dated notes about changes to the project in this file in reverse chronological order
- And other such as Continuous integration (at the end of the article).https://gricad-gitlab.univ-grenoble-alpes.fr/omegalpes/omegalpes/-/issues/46Partially fixed / variable energy unit to create2019-11-26T19:55:33+01:00Sacha HodencqPartially fixed / variable energy unit to createAn energy unit with partially fixed load or production could be handy in many cases.
Two ways to do so can be considered :
- A variable energy unit with fixed pmax and pmin for the relevant time steps (easy way)
- A fixed energy unit w...An energy unit with partially fixed load or production could be handy in many cases.
Two ways to do so can be considered :
- A variable energy unit with fixed pmax and pmin for the relevant time steps (easy way)
- A fixed energy unit where only a portion is fixed. To do so, a work on the imposed vlen of p defined in Quantities and on the opt parameter as a list or dict must be lead (sophisticated way).Sacha HodencqSacha Hodencqhttps://gricad-gitlab.univ-grenoble-alpes.fr/omegalpes/omegalpes/-/issues/45e_tot calculation for storage2019-11-27T14:31:33+01:00Sacha Hodencqe_tot calculation for storage<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "Bug" label, following this link :
- https://gricad-gitlab.univ-grenoble-alpes.fr/omegalpes/omegalpes/issues?label_name%...<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "Bug" label, following this link :
- https://gricad-gitlab.univ-grenoble-alpes.fr/omegalpes/omegalpes/issues?label_name%5B%5D=bug
and verify the issue you're about to submit isn't a duplicate.
--->
### Summary
The e_tot calculation is defined in EnergyUnits as :
`{0}_e_tot == time.DT * lpSum({0}_p[t]for t in time.I`
while p[t] in storage units is calculated as :
`{0}_p[t] == {0}_pc[t] - {0}_pd[t]`
### Steps to reproduce
Opening the storage design example and printing e_tot
`print(STORAGE.e_tot)`
### What is the current *bug* behavior?
The previous command gives a wrong result for e_tot but the right result for the difference between e_ch and e_disch that can be obtained as follow:
`print("sum pcharge", sum(STORAGE.pc.value.values()))
print("sum pdischarge", sum(STORAGE.pd.value.values()))`
### What is the expected *correct* behavior?
e_ch and e_disch should be created and easily accessible, and e_tot also accessible but indicated as the difference between e_ch and e_dischSacha HodencqSacha Hodencqhttps://gricad-gitlab.univ-grenoble-alpes.fr/omegalpes/omegalpes/-/issues/34Double print of unit creation2019-11-26T16:18:24+01:00EXT HodencqDouble print of unit creation<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "Bug" label, following this link :
- https://gricad-gitlab.univ-grenoble-alpes.fr/omegalpes/omegalpes/issues?label_name%...<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "Bug" label, following this link :
- https://gricad-gitlab.univ-grenoble-alpes.fr/omegalpes/omegalpes/issues?label_name%5B%5D=bug
and verify the issue you're about to submit isn't a duplicate.
--->
### Summary
The created units have several messages showing they have been created instead of one
### Steps to reproduce
Can be checked in any example
### Possible fixes
The bug may be caused by the multi-inheritances of units
### Note : we will only investigate if the tests are passingCamille PajotCamille Pajothttps://gricad-gitlab.univ-grenoble-alpes.fr/omegalpes/omegalpes/-/issues/30Soc min and soc max checks when lists2019-11-25T10:48:03+01:00EXT HodencqSoc min and soc max checks when lists<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "Bug" label, following this link :
- https://gricad-gitlab.univ-grenoble-alpes.fr/omegalpes/omegalpes/issues?label_name%...<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "Bug" label, following this link :
- https://gricad-gitlab.univ-grenoble-alpes.fr/omegalpes/omegalpes/issues?label_name%5B%5D=bug
and verify the issue you're about to submit isn't a duplicate.
--->
### Summary
In the storage unit, there are two times the soc_min and soc_max are not properly checked when their type is list :
- line 116 : the elements of a list of soc_min should be below the elements of a list of soc_max OR a float soc_min should be below any element of a list of soc_max OR the elements of a list of soc_min should be below a float soc_max.
- line 238 when e_f is not None and capacity is not None, ValueError should be raised when e_f set out of bounds, when soc_min and soc_max are floats but also when they are one of the two are lists
### Possible fixes
- l 238 : Todo : the checks hereunder, taking into account soc_min and soc_max can be int or float but also lists !
if capacity is not None and (e_f > soc_max * capacity or
e_f < soc_min * capacity):
# the e_f value should be in between :
# [soc_min*capacity; soc_max*capacity]
raise ValueError('e_f should be in the following boundaries '
'[soc_min*capacity; soc_max*capacity] but '
'is {0}'.format(e_f))
else:Sacha HodencqSacha Hodencqhttps://gricad-gitlab.univ-grenoble-alpes.fr/omegalpes/omegalpes/-/issues/24déplacement du projet2018-11-20T09:03:08+01:00Benoit Delinchantdéplacement du projetIl y a des conséquences au déplacement du projet.
Par exemple il faut mettre à jour les informations d'installation :
pip install git+https://gricad-gitlab.univ-grenoble-alpes.fr/OptimisationQuartier/omegalpes.gitIl y a des conséquences au déplacement du projet.
Par exemple il faut mettre à jour les informations d'installation :
pip install git+https://gricad-gitlab.univ-grenoble-alpes.fr/OptimisationQuartier/omegalpes.gitLou MorrietLou Morriet2018-11-21https://gricad-gitlab.univ-grenoble-alpes.fr/omegalpes/omegalpes/-/issues/23Integration test example2018-11-14T17:05:49+01:00EXT HodencqIntegration test exampleCreating an example using a large amount of modules and methods with an associated integration test, in order to check the proper operation of the modules.Creating an example using a large amount of modules and methods with an associated integration test, in order to check the proper operation of the modules.https://gricad-gitlab.univ-grenoble-alpes.fr/omegalpes/omegalpes/-/issues/19New parameters for storage and conversion units2019-05-02T16:45:04+02:00EXT HodencqNew parameters for storage and conversion unitsAdding auto-discharging, charging and discharging efficacities parameters for the storage units, and losses for Elec2Heat conversion units as a percentage of the produced heat. Possibility to make losses a convesion unit attribute. Still...Adding auto-discharging, charging and discharging efficacities parameters for the storage units, and losses for Elec2Heat conversion units as a percentage of the produced heat. Possibility to make losses a convesion unit attribute. Still has to be checked.
Already in the dev_omegalpes_sh repositoryEXT Jaume FitóEXT Jaume Fitóhttps://gricad-gitlab.univ-grenoble-alpes.fr/omegalpes/omegalpes/-/issues/17Plots : plotting both node_energetic_flows and quantities2018-10-24T14:24:30+02:00EXT HodencqPlots : plotting both node_energetic_flows and quantitiesAt the moment, you can't use both plot_node_energetic_flows AND plot_quantity, because for this last function, you need to define figures, axes and legend, and to do a plt.legend=legend1, whereas it is all defined in the function for plo...At the moment, you can't use both plot_node_energetic_flows AND plot_quantity, because for this last function, you need to define figures, axes and legend, and to do a plt.legend=legend1, whereas it is all defined in the function for plot_node_energetic_flows.https://gricad-gitlab.univ-grenoble-alpes.fr/omegalpes/omegalpes/-/issues/13Examples improvements2018-10-24T14:22:14+02:00EXT HodencqExamples improvementsImproving the examples, and especially the system operation dataImproving the examples, and especially the system operation dataCamille PajotCamille Pajothttps://gricad-gitlab.univ-grenoble-alpes.fr/omegalpes/omegalpes/-/issues/7Add AUTHORS.rst and README.rst2019-03-27T09:01:11+01:00Lou MorrietAdd AUTHORS.rst and README.rst— AUTHORS.md : Liste des auteurs et contributeurs. Ce fichier peut être divisé en sections ( e.g. Ini- tiateurs , Développeurs , Contributeurs ). L’ajout des adresses mails à ce fichier est sujet à caution (risque de spam).
— README.md...— AUTHORS.md : Liste des auteurs et contributeurs. Ce fichier peut être divisé en sections ( e.g. Ini- tiateurs , Développeurs , Contributeurs ). L’ajout des adresses mails à ce fichier est sujet à caution (risque de spam).
— README.md : Description générale du projet, comprenant : — Une description rapide (en quelques lignes/paragraphes), avec indication du type de licence et l’origine du projet — Une description des grandes fonctionnalités — Un paragraphe sur la manière de tester le projet (installation, docker, . . .) — Les liens importants (papiers, documentation, projets annexes)Lou MorrietLou Morriethttps://gricad-gitlab.univ-grenoble-alpes.fr/omegalpes/omegalpes/-/issues/5docstring2019-07-17T19:53:24+02:00EXT HodencqdocstringFilling in the doscstrings for the different modules and classes.Filling in the doscstrings for the different modules and classes.https://gricad-gitlab.univ-grenoble-alpes.fr/omegalpes/omegalpes/-/issues/3check pep82019-12-09T14:23:16+01:00Lou Morrietcheck pep8afin de s’assurer d’avoir une qualité de code correcte sont :
— black: formate automatiquement le code source (non configurable)
— flake8: mesure le respect de la PEP-8
— pylint: mesure la qualité du code (PEP-8 et analyse statique)
Le ...afin de s’assurer d’avoir une qualité de code correcte sont :
— black: formate automatiquement le code source (non configurable)
— flake8: mesure le respect de la PEP-8
— pylint: mesure la qualité du code (PEP-8 et analyse statique)
Le formatage par défaut de black respecte en grande partie la PEP-8, tout en faisant l’impasse sur
certaines règles. Par défaut, black s’assure que les lignes ne dépassent pas 88 caractères (contre 80 selon
la PEP-8) et ajoute des espaces, virgules et parenthèses afin de simplifier la lecture et l’ajout de lignes au
code. Ce comportement déclenche des alertes lors des analyses par les outils flake8 et pylint, qui devront
être configurés en conséquence.Camille PajotCamille Pajothttps://gricad-gitlab.univ-grenoble-alpes.fr/omegalpes/omegalpes/-/issues/2add version and docformat2019-07-17T19:55:20+02:00Lou Morrietadd version and docformatAdd in each module:
__version_info__ Version sous forme de tuple d’entiers :(1, 0, 0)
__version__ Version en chaîne de caractères : “1.0.0”, ou encore
[str(x) for x in __version_info__]
__docformat__ Format de documentation (“restructur...Add in each module:
__version_info__ Version sous forme de tuple d’entiers :(1, 0, 0)
__version__ Version en chaîne de caractères : “1.0.0”, ou encore
[str(x) for x in __version_info__]
__docformat__ Format de documentation (“restructuredtext en”Camille PajotCamille Pajot