From 4d974e8854dbc506f154efca8879da3f310bb2b9 Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@ericsson.com>
Date: Tue, 15 Jul 2014 13:04:31 -0400
Subject: [PATCH] Add test for string evaluation with "debug expression" on

As Joel pointed out in...
https://sourceware.org/ml/gdb-patches/2014-07/msg00391.html
...it would be nice to add a test for that.

Tested on Linux x86_64 (Ubuntu 14.10).

gdb/testsuite/ChangeLog

2014-07-15  Simon Marchi  <simon.marchi@ericsson.com>

	* gdb.base/debug-expr.exp: Test string evaluation with
	"debug expression" on.
---
 gdb/testsuite/ChangeLog               | 5 +++++
 gdb/testsuite/gdb.base/debug-expr.exp | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 151edf76a8a..3f3ba6067f0 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2014-07-15  Simon Marchi  <simon.marchi@ericsson.com>
+
+	* gdb.base/debug-expr.exp: Test string evaluation with
+	"debug expression" on.
+
 2014-07-15  Pedro Alves  <palves@redhat.com>
 
 	* gdb.base/reread.exp: Use clean_restart.
diff --git a/gdb/testsuite/gdb.base/debug-expr.exp b/gdb/testsuite/gdb.base/debug-expr.exp
index d7c82b06780..557609174c1 100644
--- a/gdb/testsuite/gdb.base/debug-expr.exp
+++ b/gdb/testsuite/gdb.base/debug-expr.exp
@@ -50,3 +50,8 @@ gdb_test_no_output "set debug expression 1"
 # This caused gdb to segfault.
 test_debug_expr "print /x {char\[4\]} array" \
     "\[$\]$decimal = \\{0x0, 0x1, 0x2, 0x3\\}"
+
+# This caused gdb to output garbage and possibly segfault
+gdb_test "print \"hello\"" \
+    ".*OP_STRING\[^\r\n\]*Language-specific string type: 0.*\[\r\n\]\\$$decimal = \"hello\"\[\r\n\].*" \
+    "String evaluation with debug expr"
-- 
GitLab