David Beniamine (2902d701) at 28 Mar 11:51
Doc updated
David Beniamine (5cf25bae) at 28 Mar 11:48
Fix compatibility
David Beniamine (a2e3d59e) at 27 Mar 23:30
Finish handleDelete with modern ajax call
David Beniamine (1dff7844) at 21 Mar 15:38
WIP : javascript to intercept delete activity
David Beniamine (687d0e04) at 19 Mar 22:55
Proof of concept rewriting delete action
David Beniamine (d31cdb27) at 07 Mar 15:32
phpdoc
David Beniamine (5982a430) at 07 Mar 14:53
Remove debug flag
Retours de la review
$CFG
properties. Plugin-scope settings can be obtained only via get_config() call. New activity modules should use 'mod_mymodule/setting' instead of 'mymodule/setting' as identifier. For instance, instead of 'labnbook_api_url', it should be 'mod_labnbook/api_url'.mod_form.php
mod_form.php#L40
. Use get_string instead of hardcoding the string.$PAGE->requires->js_call_amd
.mod_form.php#L216
: add_intro_editor()
is deprecated. Use moodleform_mod::standard_intro_elements()
insteadmod_form.php#L264
: How is the addInputInt
method used? => not used anymore
classes/fecther.php
fetcher.php#L52
: stdClass instead of StdClass.version.php
: the supported property specifies the lowest and highest branches of Moodle that the plugin supports. According to the plugins directory, Moodle 4.2 is supported, so the value should be [37, 402]; although I've tested it with the later development version, 403 is also supported.
class mod_labnbook\ar\labnbook
: The class is not used.
README
: Is it required to run composer? The plugin seems installable without running Composer.
Connection to "process /usr/sbin/sendmail -bs" has been closed unexpectedly (Error 500).
David Beniamine (06be7264) at 07 Mar 10:35
Add licences
David Beniamine (9f3bd943) at 29 Feb 23:03
Migrate settings to set_config / get_config
David Beniamine (89150263) at 29 Feb 15:56
Update require