From 7fdb6489eb45b7e2a60598eff4de4bd1269b4844 Mon Sep 17 00:00:00 2001
From: Astor Bizard <astor.bizard@grenoble-inp.fr>
Date: Mon, 30 Mar 2020 10:32:19 +0200
Subject: [PATCH] Fixed bug where teachers could not download corrupted groups
submissions.
---
views/downloadsubmission.php | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/views/downloadsubmission.php b/views/downloadsubmission.php
index b885abaf..7305b486 100644
--- a/views/downloadsubmission.php
+++ b/views/downloadsubmission.php
@@ -59,7 +59,8 @@ if (! $subinstance) {
if ($subinstance->vpl != $vpl->get_instance()->id) {
throw new moodle_exception( 'vpl submission vpl inconsistence' );
}
-if ($vpl->is_inconsistent_user( $subinstance->userid, $userid )) {
+if ($vpl->is_inconsistent_user( $subinstance->userid, $userid ) && !$vpl->has_capability( VPL_GRADE_CAPABILITY )) {
+ // A student can't download another student/group's submission.
throw new moodle_exception( 'nopermissions', null, null, get_string('download') );
}
$submission = new mod_vpl_submission( $vpl, $subinstance );
--
GitLab