- 03 May, 2021 2 commits
-
-
Emmanuel Promayon authored
Resolve "Packaging configuration does not define Core::libDir" Closes #125 See merge request !183
-
Emmanuel Promayon authored
-
- 01 May, 2021 1 commit
-
-
Emmanuel Promayon authored
Update copyright year See merge request !182
-
- 30 Apr, 2021 4 commits
-
-
Emmanuel Promayon authored
-
Emmanuel Promayon authored
-
Emmanuel Promayon authored
-
Emmanuel Promayon authored
-
- 29 Apr, 2021 1 commit
-
-
Emmanuel Promayon authored
Improve source code safety using static analysis See merge request !181
-
- 28 Apr, 2021 5 commits
-
-
Emmanuel Promayon authored
-
Emmanuel Promayon authored
Also fix the compilation error on Linux due to the use of qDebug in Core (to manage very rare case linked with bad installation on windows)
-
Emmanuel Promayon authored
-
Emmanuel Promayon authored
-
Emmanuel Promayon authored
-
- 27 Apr, 2021 4 commits
-
-
Emmanuel Promayon authored
-
Emmanuel Promayon authored
-
Emmanuel Promayon authored
-
Emmanuel Promayon authored
-
- 25 Mar, 2021 3 commits
-
-
Emmanuel Promayon authored
* clang now supported (but still not in CI) * (nearly) gcc 9 and clang 11 warnings fixed * fixed all CMake warnings (in CamiTK CE + generated CEP) * include a new mechanisms to suppress extra warnings on external headers (namely VTK) with clang while keeping all internal warning (see CamiTKDisableWarnings for more information * On Linux, you can now build CamiTK CE with clang or gcc and (independently) develop your CEP with clang or gcc
-
Emmanuel Promayon authored
* CamiTK CE now compiled with C++17 standard * CMake minimal version raised to 3.13 * All warnings are shown (flag -Wall) * CMake warnings about CMP0046 fixed (now properly adding external dependencies) * Cleanup CMake message (all message now has a classifier, e.g., STATUS)
-
Emmanuel Promayon authored
* No more warning on currently supported CMake version * log is now clean and more informative of the different steps
-
- 23 Mar, 2021 3 commits
-
-
Emmanuel Promayon authored
cppcheck ran with --enable=performance --enable=portability --library=qt -i ./CMakeFiles Fixed two things: - (performance) Prefer prefix ++/-- operators for non-primitive types. - (performance) Variable assigned in constructor body moved to initialization list.
-
Emmanuel Promayon authored
Clazy is a clang compiler plugin which emits warnings related to Qt best practices. This includes all (see [1] for details) - fully-qualified-moc-types - qstring-args - qenums And most (but not all as there was some false positive or some that required more complete rewrite) - container-anti-pattern - range-loop Note that: non-pod-global-static, connect-3arg-lambda, qtpropertybrowser and source code generated by xsdcxx were not modified. [1] https://github.com/KDE/clazy#list-of-checks
-
Emmanuel Promayon authored
-
- 22 Mar, 2021 3 commits
-
-
Emmanuel Promayon authored
-
Emmanuel Promayon authored
-
Emmanuel Promayon authored
1. Invoking virtual functions from constructors or destructors ============================================================== This was found in helper classes directly deriving from Interface class (Geometry, GeometricObject, Frame, Slice) or classes that inherits from Component (SingleImageComponent, ArbitrarySingleImageComponent, or Component itself) Three solutions were used: - solution 1: When methods are private, just remove the unjustified virtual keyword - solution 2: declare virtual method called in constructor as final, see OOP50-CPP-EX2 of SEI CERT C++ Coding Standard [1] - solution 3: call the virtual function with an explicitly qualified ID (e.g, Application::eventFilter), see OOP50-CPP-EX1 of SEI CERT C++ Coding Standard [1] 2. QtPropertyBrowser exceptions =============================== qtpropertybrowser source code was not modified to facilitate keeping it sync whith other forks. 3. Potential memory leak ======================== Sometimes new QEvent(...) are used in Application, InteractiveViewer, ActionState are used to force updates. Cland tidy generate a "potential memory leak" warning. This was left in the code as it is not necessarily true (see [2]). [1] https://wiki.sei.cmu.edu/confluence/display/cplusplus/OOP50-CPP.+Do+not+invoke+virtual+functions+from+constructors+or+destructors [2] https://stackoverflow.com/a/54655746
-
- 19 Mar, 2021 1 commit
-
-
Emmanuel Promayon authored
redirecting post build log to proper log directory See merge request !180
-
- 18 Mar, 2021 3 commits
-
-
Emmanuel Promayon authored
-
Emmanuel Promayon authored
Resolve "Update upstream-ci/master in order to fix package build" Closes #117 See merge request !179
-
Emmanuel Promayon authored
-
- 17 Mar, 2021 5 commits
-
-
Emmanuel Promayon authored
Resolve "Update upstream-ci/master in order to fix package build" Closes #117 See merge request !178
-
Emmanuel Promayon authored
-
Emmanuel Promayon authored
Resolve "Update upstream-ci/master in order to fix package build" Closes #117 See merge request !177
-
Emmanuel Promayon authored
-
Emmanuel Promayon authored
Resolve "Update upstream-ci/master in order to fix package build" Closes #117 See merge request !176
-
- 16 Mar, 2021 4 commits
-
-
Emmanuel Promayon authored
-
Emmanuel Promayon authored
Resolve "Update upstream-ci/master in order to fix package build" Closes #117 See merge request !175
-
Emmanuel Promayon authored
Directly include GNUInstallDirs on UNIX in order to support multiarch based on GNU defined installation standards
-
Emmanuel Promayon authored
Resolve "Update upstream-ci/master in order to fix package build" Closes #117 See merge request !174
-
- 15 Mar, 2021 1 commit
-
-
Emmanuel Promayon authored
-