GitLab

Resolve "Packaging configuration does not define Core::libDir"

Closes #125

See merge request !183

Update copyright year

See merge request !182

Improve source code safety using static analysis

See merge request !181

Also fix the compilation error on Linux due to the use of qDebug in Core
(to manage very rare case linked with bad installation on windows)

* clang now supported (but still not in CI)
* (nearly) gcc 9 and clang 11 warnings fixed
* fixed all CMake warnings (in CamiTK CE + generated CEP)
* include a new mechanisms to suppress extra warnings on
  external headers (namely VTK) with clang while keeping
  all internal warning (see CamiTKDisableWarnings for more
  information
* On Linux, you can now build CamiTK CE with clang or gcc
  and (independently) develop your CEP with clang or gcc

* CamiTK CE now compiled with C++17 standard
* CMake minimal version raised to 3.13
* All warnings are shown (flag -Wall)
* CMake warnings about CMP0046 fixed (now properly adding external dependencies)
* Cleanup CMake message (all message now has a classifier, e.g., STATUS)

* No more warning on currently supported CMake version
* log is now clean and more informative of the different steps

cppcheck ran with --enable=performance --enable=portability --library=qt -i ./CMakeFiles

Fixed two things:
- (performance) Prefer prefix ++/-- operators for non-primitive types.
- (performance) Variable assigned in constructor body moved to initialization list.

Clazy is a clang compiler plugin which emits warnings related to Qt best practices.

This includes all (see [1] for details)
- fully-qualified-moc-types
- qstring-args
- qenums

And most (but not all as there was some false positive or some that required more complete rewrite)
- container-anti-pattern
- range-loop

Note that: non-pod-global-static, connect-3arg-lambda, qtpropertybrowser and source code generated by xsdcxx were not modified.

[1] https://github.com/KDE/clazy#list-of-checks

1. Invoking virtual functions from constructors or destructors
==============================================================

This was found in helper classes directly deriving from Interface class (Geometry, GeometricObject, Frame, Slice)
or classes that inherits from Component (SingleImageComponent, ArbitrarySingleImageComponent, or Component itself)

Three solutions were used:

- solution 1: When methods are private, just remove the unjustified virtual keyword
- solution 2: declare virtual method called in constructor as final, see OOP50-CPP-EX2 of SEI CERT C++ Coding Standard [1]
- solution 3: call the virtual function with an explicitly qualified ID (e.g, Application::eventFilter), see OOP50-CPP-EX1 of SEI CERT C++ Coding Standard
 [1]

2. QtPropertyBrowser exceptions
===============================

qtpropertybrowser source code was not modified to facilitate keeping it sync whith other forks.

3. Potential memory leak
========================

Sometimes new QEvent(...) are used in Application, InteractiveViewer, ActionState are used to force updates. Cland tidy generate a "potential memory leak"
 warning. This was left in the code as it is not necessarily true (see [2]).

[1] https://wiki.sei.cmu.edu/confluence/display/cplusplus/OOP50-CPP.+Do+not+invoke+virtual+functions+from+constructors+or+destructors
[2] https://stackoverflow.com/a/54655746

redirecting post build log to proper log directory

See merge request !180

Resolve "Update upstream-ci/master in order to fix package build"

Closes #117

See merge request !179

Resolve "Update upstream-ci/master in order to fix package build"

Closes #117

See merge request !178

Resolve "Update upstream-ci/master in order to fix package build"

Closes #117

See merge request !177

Resolve "Update upstream-ci/master in order to fix package build"

Closes #117

See merge request !176

Resolve "Update upstream-ci/master in order to fix package build"

Closes #117

See merge request !175

Directly include GNUInstallDirs on UNIX in order to support multiarch based on GNU defined installation standards

Resolve "Update upstream-ci/master in order to fix package build"

Closes #117

See merge request !174