Vous avez reçu un message "Your GitLab account has been locked ..." ? Pas d'inquiétude : lisez cet article https://docs.gricad-pages.univ-grenoble-alpes.fr/help/unlock/

Commit 9bd79aa6 authored by Emmanuel Promayon's avatar Emmanuel Promayon
Browse files

FIXED test policy

When a test fails or is expected to fail on a specific plateform
or a specific version of a dependency (VTK, ITK...) it should not
be marked as WILL_FAILED, it should just be disabled.
parent c2c7996b
......@@ -20,27 +20,33 @@ camitk_extension(ACTION_EXTENSION
ENABLE_INTEGRATION_TEST
)
# --------------------------------
# --- Specific test management ---
# --------------------------------
# Test failure due to ITK exception
# For now consider these fail tests as passed until this can be taken care of in the save() method
# For now disable these tests until this can be taken care of in the save() method
# TODO check if it possible to avoid this exception
# For input file: biorad.pic
# Applying action Gradient Magnitude With Smoothing...
# camitk-testcomponents aborted by std exception: /usr/include/ITK-4.10/itkRecursiveSeparableImageFilter.hxx:245:
# itk::ERROR: RecursiveGaussianImageFilter(0x55b3b21bc700): The number of pixels along direction 2 is less than 4. This filter requires a minimum of four pixels along the dimension to be processed...
set_tests_properties("action-itkfilters-level1-6" PROPERTIES WILL_FAIL true)
set_tests_properties("action-itkfilters-level1-6" PROPERTIES DISABLED true)
# For input file: cthead1.lsm
# Applying action Gradient Magnitude With Smoothing...
# camitk-testcomponents aborted by std exception: /usr/include/ITK-4.10/itkRecursiveSeparableImageFilter.hxx:245:
# itk::ERROR: RecursiveGaussianImageFilter(0x559652ac6cc0): The number of pixels along direction 2 is less than 4. This filter requires a minimum of four pixels along the dimension to be processed..
set_tests_properties("action-itkfilters-level1-8" PROPERTIES WILL_FAIL true)
set_tests_properties("action-itkfilters-level1-8" PROPERTIES DISABLED true)
# For input file: mini-complex-slow1.nrrd
# Applying action Gradient Magnitude With Smoothing...
# camitk-testcomponents aborted by std exception: /usr/include/ITK-4.10/itkRecursiveSeparableImageFilter.hxx:245:
# itk::ERROR: RecursiveGaussianImageFilter(0x55f942cacac0): The number of pixels along direction 2 is less than 4. This filter requires a minimum of four pixels along the dimension to be processed.
set_tests_properties("action-itkfilters-level1-14" PROPERTIES WILL_FAIL true)
set_tests_properties("action-itkfilters-level1-14" PROPERTIES DISABLED true)
# Tests fail due to OpenGL crashing when used inside a VM
# As the test can be run directly on a "real" desktop, add the test but flag it with WILL_FAIL
if(WIN32)
set_tests_properties(action-itkfilters-integration-test PROPERTIES WILL_FAIL true)
message(WARNING "Disabling test action-itkfilters-integration-test\n"
"Reason: WIN32 OpenGL failure on a VM\n"
"This test fails when run inside a VM due to OpenGL crash.\n"
"This test passes when run directly from a physical windows machine.\n")
set_tests_properties(action-itkfilters-integration-test PROPERTIES DISABLED true)
endif()
......@@ -8,39 +8,45 @@ camitk_extension(COMPONENT_EXTENSION
ENABLE_AUTO_TEST
)
# --------------------------------
# --- Specific test management ---
# --------------------------------
# Test failure due to ITK exception
# For now consider these fail tests as passed until this can be taken care of in the save() method
# For now disable these tests until this can be taken care of in the save() method
# TODO check if it possible to avoid this exception
# Trying to save "biorad.pic" generates the following ITK Exception:
# /build/insighttoolkit4-zpsE3g/insighttoolkit4-4.10.1-dfsg1/Modules/IO/BioRad/src/itkBioRadImageIO.cxx:484:
# itk::ERROR: BioRadImageIO(0x55bf9bc9bb90): Component type not supported.
set_tests_properties("component-itkimage-level3-9" PROPERTIES WILL_FAIL true)
set_tests_properties("component-itkimage-level3-9" PROPERTIES DISABLED true)
# Saving Error: problem occurs while saving file:/home/promayon/Dev/CamiTK/build/camitk/Testing/Temporary/component-itkimage-level3-10/cthead1.lsm: ITK Exception: /build/insighttoolkit4-zpsE3g/insighttoolkit4-4.10.1-dfsg1/Modules/IO/LSM/src/itkLSMImageIO.cxx:275:
# itk::ERROR: LSMImageIO(0x55a165be7310): TIFF supports unsigned char and unsigned short
set_tests_properties("component-itkimage-level3-10" PROPERTIES WILL_FAIL true)
set_tests_properties("component-itkimage-level3-10" PROPERTIES DISABLED true)
# Test failure due to bad export
# TODO check why ITK cannot save BigEndian.spr properly
set_tests_properties("component-itkimage-level3-3" PROPERTIES WILL_FAIL true)
set_tests_properties("component-itkimage-level3-3" PROPERTIES DISABLED true)
# TODO check why ITK cannot save LittleEndianZ.hdr properly
set_tests_properties("component-itkimage-level3-19" PROPERTIES WILL_FAIL true)
set_tests_properties("component-itkimage-level3-19" PROPERTIES DISABLED true)
# TODO check why ITK cannot save LittleEndianZ.img.gz properly
set_tests_properties("component-itkimage-level3-20" PROPERTIES WILL_FAIL true)
set_tests_properties("component-itkimage-level3-20" PROPERTIES DISABLED true)
if(WIN32)
# TODO check why BigEndianCompressed.img.gz does not work on Windows (maybe because of double suffix .im.gz?)
set_tests_properties(component-itkimage-level3-6 PROPERTIES WILL_FAIL true)
message(WARNING "Disabling test component-itkimage-level3-6 component-itkimage-level3-16 and component-itkimage-level3-28\n"
"Reason: WIN32 failure (probably) due to double suffix .im.gz or .nii.gz\n")
# TODO confirm diagnostic: check why BigEndianCompressed.img.gz does not work on Windows (maybe because of double suffix .im.gz?)
set_tests_properties(component-itkimage-level3-6 PROPERTIES DISABLED true)
# same for LittleEndianCompressed.img.gz
set_tests_properties(component-itkimage-level3-16 PROPERTIES WILL_FAIL true)
set_tests_properties(component-itkimage-level3-16 PROPERTIES DISABLED true)
# same for minimal.nii.gz
set_tests_properties(component-itkimage-level3-28 PROPERTIES WILL_FAIL true)
set_tests_properties(component-itkimage-level3-28 PROPERTIES DISABLED true)
endif()
# On Ubuntu 18.04 LTS, the default ITK version is 4.12
# ITK 4.12 handle export to some format differently that generates different file and therefore
# test errors for level3
# The following exception should be removed when all plateforms are based on ITK 4.12 or higher
if("${ITK_VERSION}" VERSION_GREATER 4.11)
message(WARNING "Disabling test component-itkimage-level3-1 component-itkimage-level3-4 component-itkimage-level3-7 component-itkimage-level3-11 component-itkimage-level3-13 component-itkimage-level3-15 component-itkimage-level3-17 component-itkimage-level3-21 component-itkimage-level3-28\n"
"Reason: ITK version is greater than 4.11\n"
"ITK 4.12 handle export to some format differently. It generates different files and therefore\n"
"generates test errors for level3.\n"
"The following test should be enabled when all plateforms are based on ITK 4.12 or higher\n")
set_tests_properties(component-itkimage-level3-1
component-itkimage-level3-4
component-itkimage-level3-7
......@@ -50,7 +56,7 @@ if("${ITK_VERSION}" VERSION_GREATER 4.11)
component-itkimage-level3-17
component-itkimage-level3-21
component-itkimage-level3-28
PROPERTIES WILL_FAIL true)
PROPERTIES DISABLED true)
endif()
# Additional test for SDK actions: this will add auto test for the given actions using the itkimage component
......
......@@ -10,14 +10,23 @@ camitk_extension(ACTION_EXTENSION
# Recursively update the shiboken path variable containing the CamiTK SDK tree structure
set(SHIBOKEN_CAMITK_SDK_PATH ${SHIBOKEN_CAMITK_SDK_PATH}:${CMAKE_CURRENT_SOURCE_DIR} CACHE INTERNAL "")
# On Ubuntu 16.04 LTS, the default VTK version is 6.2 not 6.3
# VTK6.2 has a bug when it saves vtk files: it does not save the proper VTK file format version
# --------------------------------
# --- Specific test management ---
# --------------------------------
if("${VTK_VERSION}" VERSION_LESS 6.3)
set_tests_properties(action-reconstruction-integration-test PROPERTIES WILL_FAIL true)
message(WARNING "Disabling test action-reconstruction-integration-test\n"
"Reason: VTK version is less than 6.3\n"
"VTK6.2 has a bug when it saves vtk files: it does not save the proper VTK file format version\n"
"On Ubuntu 16.04 LTS, the default VTK version is 6.2 not 6.3.\n"
"Ubuntu 16.04 LTS is supported but these test will fail if not disabled\n")
set_tests_properties(action-reconstruction-integration-test PROPERTIES DISABLED true)
endif()
# Tests fail due to OpenGL crashing when used inside a VM
# As the test can be run directly on a "real" desktop, add the test but flag it with WILL_FAIL
if(WIN32)
set_tests_properties(action-reconstruction-integration-test PROPERTIES WILL_FAIL true)
message(WARNING "Disabling test action-reconstruction-integration-test\n"
"Reason: WIN32 OpenGL failure on a VM\n"
"This test fails when run inside a VM due to OpenGL crash.\n"
"This test passes when run directly from a physical windows machine.\n")
set_tests_properties(action-reconstruction-integration-test PROPERTIES DISABLED true)
endif()
......@@ -17,10 +17,16 @@ camitk_extension(COMPONENT_EXTENSION
# Recursively update the shiboken path variable containing the CamiTK SDK tree structure
set(SHIBOKEN_CAMITK_SDK_PATH ${SHIBOKEN_CAMITK_SDK_PATH}:${CMAKE_CURRENT_SOURCE_DIR} CACHE INTERNAL "")
# On Ubuntu 16.04 LTS, the default VTK version is 6.2 not 6.3
# VTK6.2 has a bug when it saves vtk files: it does not save the proper VTK file format version
# These tests are disabled until Ubuntu LTS 18.04 is released (LTS 18.04 contains VTK 6.3)
# --------------------------------
# --- Specific test management ---
# --------------------------------
if("${VTK_VERSION}" VERSION_LESS 6.3)
message(WARNING "Disabling test component-vtkmesh-level3-1 to component-vtkmesh-level3-16\n"
"Reason: VTK version is less than 6.3\n"
"VTK6.2 has a bug when it saves vtk files: it does not save the proper VTK file format version\n"
"On Ubuntu 16.04 LTS, the default VTK version is 6.2 not 6.3.\n"
"Ubuntu 16.04 LTS is supported but these test will fail if not disabled\n")
set_tests_properties(component-vtkmesh-level3-1
component-vtkmesh-level3-2
component-vtkmesh-level3-3
......@@ -37,5 +43,5 @@ if("${VTK_VERSION}" VERSION_LESS 6.3)
component-vtkmesh-level3-14
component-vtkmesh-level3-15
component-vtkmesh-level3-16
PROPERTIES WILL_FAIL true)
PROPERTIES DISABLED true)
endif()
......@@ -5,5 +5,8 @@ camitk_extension(COMPONENT_EXTENSION
AUTO_TEST_LEVEL 1
)
# --------------------------------
# --- Specific test management ---
# --------------------------------
# this is a guaranted test failure. Therefore test fail is correct.
set_tests_properties("component-abort-level1-1" PROPERTIES WILL_FAIL true)
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment